Skip to content

verification: remove lax on compute_fetch_challenges - #475

Open
redshiftzero wants to merge 1 commit into
mainfrom
smol-compute-lax
Open

redshiftzero wants to merge 1 commit into
mainfrom
smol-compute-lax

Conversation

@redshiftzero

Copy link
Copy Markdown
Contributor

Towards #279 by removing the while and adding a proof annotation in the loop
This doesn't do #301

@redshiftzero
redshiftzero requested review from a team as code owners November 16, 2026 20:02

@asraa asraa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so much cleaner and follows the spec steps so much closer anyway!

// TODO(#423): Handle what should happen if there are more entries than total_responses
for i in 0..total_responses {
#[cfg(hax)]
hax_lib::loop_invariant!(|i: usize| responses.len() == i);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me: was this the actual fix for "due to the push panic freedom requirement"? (is it to ensure that the capacity of responses doesn't overflow?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, the potential panic was just about the capacity overflow

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants